Added error events #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sediug
requested changes
Mar 15, 2018
There was a problem hiding this comment.
Hi there Alvaro! First of all thanks for the help 👍 💯 !!
I'm gonna suggest a few changes. I suggest we emit an error event always and not just on production mode. It's not a big change and It's good now but I think it's kind of complicated for no good reason, I prefer to trigger an event always, it's easier to understand for the final user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now in production mode everytime and error occurs, an event is emitted. #37
You can listen for errors with
goblinDB.on('error', function(...))